State migration for type values with two or more interfaces #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsainati1
approved these changes
Dec 18, 2023
|
@dsainati1 Correct! Type values which contain an intersection type are simply returned as-is, there is no conversion to a different value. However, when the type value is used as dictionary key, returning the type value from the migration value will cause it to be re-inserted into the dictionary, re-hashing the type value, which in turn will use the fixed type ID function which sorts the intersection type's interface type set. |
SupunS
reviewed
Dec 18, 2023
Co-authored-by: Supun Setunga <[email protected]>
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 26fab85 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2981 +/- ##
==========================================
- Coverage 80.01% 79.98% -0.03%
==========================================
Files 354 356 +2
Lines 82705 82862 +157
==========================================
+ Hits 66177 66279 +102
- Misses 14174 14228 +54
- Partials 2354 2355 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
6 tasks
dsainati1
approved these changes
Dec 22, 2023
SupunS
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2681
Description
Add a state migration which re-stores run-time type values (
Type) which have an intersection type with two or more interfaces. In that case, the hash value changes because the type ID generation now sorts the interface set.Heavily based on the great Account type migration from @SupunS. 👌 🙏
masterbranchFiles changedin the Github PR explorer