Handle broken contracts #3482

turbolent · 2024-07-19T22:52:05Z

Work towards #3480

Description

Implements the program recovery as described in FLIP onflow/flips#283

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

runtime/ft_test.go

github-actions · 2024-07-19T22:57:47Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 542618d
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
DecodeBatchEventsCCF-4	120ms ± 0%	122ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	358ms ± 0%	360ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.64µs ± 0%	2.73µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.98µs ± 0%	1.95µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.59µs ± 0%	2.61µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.88µs ± 0%	2.87µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.99µs ± 0%	2.02µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.39µs ± 0%	2.33µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.35µs ± 0%	2.40µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.36µs ± 0%	2.30µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	1.95µs ± 0%	1.96µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.41µs ± 0%	2.41µs ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	9.02µs ± 0%	9.40µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.20µs ± 0%	5.49µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	8.09µs ± 0%	8.46µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	11.0µs ± 0%	11.5µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	5.64µs ± 0%	5.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	6.92µs ± 0%	7.65µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	7.11µs ± 0%	7.11µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	6.42µs ± 0%	6.57µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	5.19µs ± 0%	5.19µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	7.20µs ± 0%	7.12µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	78.9ms ± 0%	80.5ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	94.9ms ± 0%	94.6ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.78µs ± 0%	1.73µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.50µs ± 0%	1.38µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.74µs ± 0%	1.69µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.06µs ± 0%	1.98µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.48µs ± 0%	1.42µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.62µs ± 0%	1.53µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.60µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.59µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.41µs ± 0%	1.41µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.64µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.21µs ± 0%	2.26µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.30µs ± 0%	1.29µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.01µs ± 0%	1.99µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.75µs ± 0%	2.81µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.32µs ± 0%	1.35µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.67µs ± 0%	1.69µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	1.94µs ± 0%	1.96µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.54µs ± 0%	1.54µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.32µs ± 0%	1.30µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	1.92µs ± 0%	1.95µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	256ns ± 0%	260ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	72.6ns ± 0%	72.4ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	1.79ms ± 0%	1.81ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	824ns ± 0%	894ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	335ns ± 0%	350ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	5.67ms ± 1%	5.67ms ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	8.79ms ± 2%	8.64ms ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	995µs ± 3%	966µs ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/With_memory_metering-4	140µs ± 3%	142µs ± 4%	~	(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4	111µs ± 4%	112µs ± 3%	~	(p=1.000 n=2+2)
ParseInfix-4	4.99µs ± 1%	5.13µs ± 2%	~	(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-4	1.75ns ± 0%	1.74ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	79.6ns ± 0%	75.1ns ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	518µs ± 0%	537µs ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.56µs ± 0%	3.62µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	209ns ± 0%	210ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	93.4ns ± 0%	95.2ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	282ns ± 0%	284ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	58.9ns ± 0%	58.8ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
DecodeBatchEventsCCF-4	66.5MB ± 0%	66.5MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	242MB ± 0%	242MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.40kB ± 0%	1.40kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.49kB ± 0%	1.49kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.26kB ± 0%	1.26kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.32kB ± 0%	1.32kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.30kB ± 0%	1.30kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.33kB ± 0%	1.33kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	5.95kB ± 0%	5.95kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.38kB ± 0%	5.38kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.30kB ± 0%	7.30kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.59kB ± 0%	3.59kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.49kB ± 0%	4.49kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.41kB ± 0%	4.41kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	63.9MB ± 0%	63.9MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	40.7MB ± 0%	40.7MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.47kB ± 0%	1.47kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.44kB ± 0%	1.44kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.46kB ± 0%	1.46kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.23kB ± 0%	1.23kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	896B ± 0%	896B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	536B ± 0%	536B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	920B ± 0%	920B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.11kB ± 0%	1.11kB ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	584B ± 0%	584B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	784B ± 0%	784B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	808B ± 0%	808B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	672B ± 0%	672B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	544B ± 0%	544B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	800B ± 0%	800B ± 0%	~	(all equal)
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	944B ± 0%	944B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.68MB ± 0%	2.68MB ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/byte_array-4	4.13MB ± 2%	4.20MB ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/With_memory_metering-4	29.8kB ± 0%	29.8kB ± 0%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	29.8kB ± 0%	29.8kB ± 0%	~	(p=0.667 n=2+2)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(p=0.333 n=2+2)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	159kB ± 0%	159kB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.36kB ± 0%	3.36kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(all equal)
DecodeBatchEventsJSON-4	4.60M ± 0%	4.60M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	124 ± 0%	124 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	100 ± 0%	100 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	157 ± 0%	157 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	68.0 ± 0%	68.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	85.0 ± 0%	85.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	84.0 ± 0%	84.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	1.00M ± 0%	1.00M ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	902k ± 0%	902k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	89.4k ± 0%	89.4k ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	3.14k ± 0%	3.14k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	50.0 ± 0%	50.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

simpler than manual elaboration construction

SupunS

Nice!

runtime/ft_test.go

- call `getType` - save to storage and load back from storage - casting to and from `FungibleToken.Vault`

turbolent · 2024-07-29T16:05:08Z

For anyone looking at this PR: This PR only adds support for the program recovery functionality as a runtime interface function. It does NOT provide an implementation. An implementation of the function is only provided for demonstration / testing purposes in a test case. Merging the PR does not change any behaviour for Cadence programs.

add test case to simulate loading broken FT contract

bddeb3b

turbolent commented Jul 19, 2024

View reviewed changes

runtime/ft_test.go Outdated Show resolved Hide resolved

turbolent added 3 commits July 22, 2024 09:21

implement partial PoC for program recovery of fungible token

d7686c8

change program recovery to syntactical replacement

d2317e7

simpler than manual elaboration construction

check conformance to FungibleToken contract interface syntactically

7d47f25

SupunS approved these changes Jul 23, 2024

View reviewed changes

SupunS reviewed Jul 24, 2024

View reviewed changes

runtime/ft_test.go Show resolved Hide resolved

runtime/ft_test.go Show resolved Hide resolved

turbolent added 5 commits July 25, 2024 15:48

improve test case

7197c69

- call `getType` - save to storage and load back from storage - casting to and from `FungibleToken.Vault`

test calling withdraw function on recovered vault

acd782a

Merge branch 'master' into bastian/3480-handle-broken-contracts

7ee056e

add new required function to empty runtime interface implementation

bc09029

Merge branch 'master' into bastian/3480-handle-broken-contracts

a789547

turbolent marked this pull request as ready for review July 29, 2024 15:34

turbolent self-assigned this Jul 29, 2024

turbolent added the Feature label Jul 29, 2024

turbolent merged commit e79cdf8 into master Jul 29, 2024
10 of 12 checks passed

turbolent deleted the bastian/3480-handle-broken-contracts branch July 29, 2024 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle broken contracts #3482

Handle broken contracts #3482

turbolent commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

SupunS left a comment

turbolent commented Jul 29, 2024 •

edited

Loading

Handle broken contracts #3482

Handle broken contracts #3482

Conversation

turbolent commented Jul 19, 2024 • edited Loading

Description

github-actions bot commented Jul 19, 2024 • edited Loading

Cadence Benchstat comparison

SupunS left a comment

Choose a reason for hiding this comment

turbolent commented Jul 29, 2024 • edited Loading

turbolent commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

turbolent commented Jul 29, 2024 •

edited

Loading