-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support expressions in string template #3625
Support expressions in string template #3625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/string-templates #3625 +/- ##
===========================================================
Coverage ? 80.18%
===========================================================
Files ? 412
Lines ? 95839
Branches ? 0
===========================================================
Hits ? 76850
Misses ? 16291
Partials ? 2698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge `string-templates` branch to `master`
e91bfae
to
d93bb65
Compare
haha, this keeps getting closed (unintentionally) 😄 Seems it's not possible to reopen/change-base without reviving the removed branch. Maybe open a new PR from the same existing branch targeting master. Or if that doesn't work, cherry-pick the commits and open a new PR. Sorry about the extra work. |
Argh, sorry, my bad! I thought all work related to string interpolation was complete, I didn't realize there was another PR. |
Working towards #3579
Description
This PR extends the work in #3585, as planned to support expressions.
feature/string-templates
branchFiles changed
in the Github PR explorer