Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old compiler and VM PoC #3705

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

turbolent
Copy link
Member

Work towards #3595


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f5e27df
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can always revive this from a tag if needed.

@turbolent turbolent merged commit 24783e3 into master Nov 29, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/remove-old-compiler-and-vm-poc branch November 29, 2024 19:55
@turbolent
Copy link
Member Author

@SupunS exactly, we can definitely reuse parts once/if we need them. At the moment it's confusing to have it on master

@jsproz jsproz requested review from jsproz and removed request for jsproz December 3, 2024 12:54
Copy link

@jsproz jsproz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Less to learn for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants