Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the number interfaces in the value-package generic #3790

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 24, 2025

Work towards #3693

Description

Depends on #3766.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Feb 24, 2025
@SupunS SupunS requested a review from turbolent as a code owner February 24, 2025 19:57
@SupunS SupunS requested a review from jsproz February 24, 2025 19:58
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit e0f959b into bastian/decouple-values-from-interpreter-4 Feb 24, 2025
@turbolent turbolent deleted the supun/bind-interface-to-type branch February 24, 2025 22:09
@turbolent
Copy link
Member

@SupunS Do you think we can also values.ComparableValue generic in a similar way?

@SupunS
Copy link
Member Author

SupunS commented Feb 24, 2025

I thought about it at the time, but for some reason ended-up not doing/trying it; Can't exactly remember why 🤔
Think it should be possible/ makes sense to do there as well

@turbolent
Copy link
Member

Sounds good! Done in 5004f33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants