Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Compile transaction pre/post conditions #3801

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 26, 2025

Work towards #3769

Description

Include the transaction pre/post conditions into the execute function, so that the existing condition desgaring logic would handle and generate code.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Feature label Feb 26, 2025
@SupunS SupunS self-assigned this Feb 26, 2025
@SupunS SupunS requested a review from turbolent as a code owner February 26, 2025 21:53
@SupunS SupunS requested a review from jsproz February 26, 2025 21:53
@SupunS SupunS force-pushed the supun/transaction-conditions branch from 7de5651 to 9f1fea6 Compare February 26, 2025 21:54
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 5a3d8c8
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SupunS SupunS merged commit 25be6fe into feature/compiler Feb 27, 2025
7 of 9 checks passed
@SupunS SupunS deleted the supun/transaction-conditions branch February 27, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants