-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StagingStatusUpdated.code event value to SHA3_256 hash #38
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 83.91% 83.81% -0.11%
==========================================
Files 6 6
Lines 342 346 +4
==========================================
+ Hits 287 290 +3
- Misses 55 56 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Maybe change the parameter code: String
of the event StagingStatusUpdated
to codeHash: [UInt8; 32]
to make the event less stringly typed and reduce the overhead of hex-encoding
Makes sense. cc-ing @bluesign in case his tooling depends on events at all. I think not, but tagging just in case |
Closes: #37
For contributor use:
main
branchFiles changed
in the Github PR explorer