-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate code to C1.0 #1
Conversation
cadence/contracts/Recipe.cdc
Outdated
import "NonFungibleToken" | ||
import "Burner" | ||
|
||
/// NB: This contract is no longer supported. NFT Storefront V2 is recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franklywatson I noticed this recipe is using the old NFTStorefront
contract (the recipe contract code was essentially a copy paste of the entire NFTStorefront
contract source code) , thoughts on updating to use the V2 contract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we should not use V1 and if we're copying the entire contract let's used the deployed version to generate a dependency and not have the code copied in full into the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franklywatson will do - it is a quick change on the front-end to make the contract.cdc/Recipe.cdc code snippet optional - I think it makes sense to just delete the Recipe.cdc
code altogether where it is a copy of a deployed contract and leave only the transaction code (same applies to some of the TS recipes)
Updated flow.json to denote the deployed address for testing context
To-do:
NFTStorefront
to the NFTStorefront V2 contract