Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code to C1.0 #1

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Migrate code to C1.0 #1

merged 9 commits into from
Dec 13, 2024

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Nov 14, 2024

To-do:

  • Look into swapping NFTStorefront to the NFTStorefront V2 contract

@lealobanov lealobanov self-assigned this Dec 8, 2024
import "NonFungibleToken"
import "Burner"

/// NB: This contract is no longer supported. NFT Storefront V2 is recommended
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franklywatson I noticed this recipe is using the old NFTStorefront contract (the recipe contract code was essentially a copy paste of the entire NFTStorefront contract source code) , thoughts on updating to use the V2 contract?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should not use V1 and if we're copying the entire contract let's used the deployed version to generate a dependency and not have the code copied in full into the project.

Copy link
Collaborator Author

@lealobanov lealobanov Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franklywatson will do - it is a quick change on the front-end to make the contract.cdc/Recipe.cdc code snippet optional - I think it makes sense to just delete the Recipe.cdc code altogether where it is a copy of a deployed contract and leave only the transaction code (same applies to some of the TS recipes)

lealobanov and others added 3 commits December 8, 2024 16:21
@lealobanov lealobanov merged commit 1549b40 into main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants