Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C1.0 migration #1

Merged
merged 22 commits into from
Dec 16, 2024
Merged

C1.0 migration #1

merged 22 commits into from
Dec 16, 2024

Conversation

lealobanov
Copy link
Collaborator

No description provided.

@lealobanov
Copy link
Collaborator Author

To-do: finish debugging

e=3387179 txID=20304bc50bc72b354a7f448e593526e28f056db2b335b5c6b2b8e727070d49c1
8:06PM WRN ERR [20304b] [Error Code: 1101] error caused by: 1 error occurred:
        * transaction execute failed: [Error Code: 1101] cadence runtime error: Execution failed:
  --> 20304bc50bc72b354a7f448e593526e28f056db2b335b5c6b2b8e727070d49c1:81:24
   |
81 |         let listingID = self.storefront.createListing(
82 |             nftProviderCapability: self.exampleNFTProvider,
83 |             nftType: Type<@ExampleNFT.NFT>(),
84 |             nftID: 1,
85 |             salePaymentVaultType: Type<@FlowToken.Vault>(),
86 |             saleCuts: [saleCut]
87 |         )
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   --> f8d6e0586b0a20c7.NFTStorefront:420:34
    |
420 |             let listing <- create Listing(
421 |                 nftProviderCapability: nftProviderCapability,
422 |                 nftType: nftType,
423 |                 nftID: nftID,
424 |                 salePaymentVaultType: salePaymentVaultType,
425 |                 saleCuts: saleCuts,
426 |                 storefrontID: self.uuid
427 |             )
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: assertion failed: cannot borrow nftProviderCapability
   --> f8d6e0586b0a20c7.NFTStorefront:351:12
    |
351 |             assert(provider != nil, message: "cannot borrow nftProviderCapability")
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@lealobanov
Copy link
Collaborator Author

All tx issues have been fixed

@lealobanov
Copy link
Collaborator Author

lealobanov commented Dec 13, 2024

Updated to use NFTStorefrontV2, removed Recipe.cdc which was a copy of the storefront contract code

@franklywatson franklywatson merged commit 8896c1e into main Dec 16, 2024
2 checks passed
@franklywatson franklywatson deleted the c1-migration branch December 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants