Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM on Flow to Flow EVM except when linking or asking why #1146

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

briandoyle81
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:28am

sidebar_position: 3
---

import BrowserOnly from '@docusaurus/BrowserOnly';
import { AddNetworkButton } from '@site/src/components/addNetworkButton';

# Using EVM On Flow
# Using Flow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "Using Flow EVM" instead of "Using Flow" so it's the same as the title and sidebar title?

@@ -4,13 +4,13 @@ import { Button } from '@site/src/ui/design-system/src/lib/Components/Button/ind
const targetChains = [
{
id: 747,
name: 'EVM on Flow',
name: 'Flow EVM Mainnet',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend just "Flow EVM" here because the name for flow evm mainnet is "Flow EVM" and not "Flow EVM Mainnet"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to just "Flow EVM"

mainnet = "Flow EVM"
testnet = "Flow EVM Testnet"

@briandoyle81 briandoyle81 merged commit 3f6e965 into main Feb 19, 2025
3 checks passed
@briandoyle81 briandoyle81 deleted the brian-doyle/cleanup-flow-evm branch February 19, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants