Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLIP 210: propose an improvement to entitlement mapping syntax #210

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

dsainati1
Copy link
Contributor

Some feedback in Discord (https://discord.com/channels/613813861610684416/1159198731422412821) revealed some room for improvement in the visual clarity of entitlement mapping declarations. This proposes to make them more visually distinct.

@dsainati1 dsainati1 requested review from turbolent and SupunS October 16, 2023 19:10
@dsainati1 dsainati1 self-assigned this Oct 16, 2023
@jacob-tucker
Copy link

I am a big fan of this because of the reasoning specified:

since one of them has default behavior for public access and the other prevents it

So this is a +1 from me.

If before Cadence 1.0 is released and there are further changes to default public access on behalf of mappings or regular entitlements, then we should revisit this again.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Even though this makes programs a bit more verbose, this is a big improvement for readability.

Especially when a entitlement or entitlement mapping is imported, reading a declaration currently requires looking up the imported declaration to see what access will be granted when accessing the member.

cadence/20231016-entitlement-mapping-syntax.md Outdated Show resolved Hide resolved
@bjartek
Copy link
Contributor

bjartek commented Oct 17, 2023

+1

At this point cadence is verbose, and this makes it easier to reason about.

@bluesign
Copy link
Collaborator

+1

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@j1010001 j1010001 added this to the OKR-23-Q4 milestone Oct 17, 2023
@j1010001 j1010001 changed the title Add FLIP proposing an improvement to entitlement mapping syntax FLIP 210: propose an improvement to entitlement mapping syntax Oct 20, 2023
@dsainati1
Copy link
Contributor Author

We discussed this in the language design meeting today and the FLIP is approved.

@dsainati1 dsainati1 merged commit 38f14bb into main Oct 24, 2023
@dsainati1 dsainati1 deleted the sainati/entitlement-mapping-syntax branch October 24, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants