-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIP 210: propose an improvement to entitlement mapping syntax #210
Conversation
I am a big fan of this because of the reasoning specified:
So this is a +1 from me. If before Cadence 1.0 is released and there are further changes to default public access on behalf of mappings or regular entitlements, then we should revisit this again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Even though this makes programs a bit more verbose, this is a big improvement for readability.
Especially when a entitlement or entitlement mapping is imported, reading a declaration currently requires looking up the imported declaration to see what access will be granted when accessing the member.
+1 At this point cadence is verbose, and this makes it easier to reason about. |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We discussed this in the language design meeting today and the FLIP is approved. |
…w/flips into sainati/entitlement-mapping-syntax
Some feedback in Discord (https://discord.com/channels/613813861610684416/1159198731422412821) revealed some room for improvement in the visual clarity of entitlement mapping declarations. This proposes to make them more visually distinct.