Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 20240730-crescendo-path-to-mainnet.md #285

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

vishalchangrani
Copy link
Contributor

@vishalchangrani vishalchangrani commented Jul 30, 2024

Introduces a method to randomly fail a percentage of transactions that have dependencies that are not staged for upgrade for Crescendo. This ensures that developers are gradually made aware of what contracts need to be staged

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FLIP explains the reasoning behind the proposal well, but it seems to completely miss the core of the design, what transactions are being failed and why. For example, it mentions nothing about imports and staged updates.

@@ -0,0 +1,44 @@
# FLIP-284: Crescendo Path to Mainnet

| Status | Accepted |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the status already accepted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( my bad. I copied the header from a pervious FLIP and forgot to change it to Drafted


## Introduction

This FLIP proposes a gradual rollout plan for the Crescendo network upgrade on Flow’s mainnet, starting with a 0% failure rate and incrementally increasing to 100% by the end of a month-long period. This approach ensures that by the, all transactions on the network will have been rigorously tested and validated, guaranteeing that Crescendo’s mainnet environment is robust and reliable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "failure rate" mean here? Maybe explain what is being failed and why

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out. I think we can update like this to fill in this gap and ideally give the additional context of the goal of the process.

This FLIP proposes a pathway in which smart contracts along with the transactions and app that use them can be validated as being staged or updated for the upcoming Crescendo release. In this rollout there will be logic deployed that ensures that all the smart contracts being used in a transaction are successfully staged for Mainnet meaning that after the Crescendo upgrade this transaction will still function. While doing this inspection if they fail the entire transaction can fail on the network so that applications and users can be aware there are missing dependencies after the Crescendo upgrade. So that we can ramp up the network and developersthe network will be building up the rate in which transactions that are inspected and fail on the network starting with a 0% rate in which failed inspected transactions fail on the network and incrementally increasing to 100% by the end of a multi-week long period. This approach ensures that by the, all transactions on the network will have been rigorously tested and validated, guaranteeing that Crescendo’s mainnet environment is robust and reliable.

@AlexHentschel AlexHentschel requested a review from turbolent August 5, 2024 19:31
@vishalchangrani vishalchangrani added the flip: governance Governance FLIP label Aug 15, 2024
@vishalchangrani
Copy link
Contributor Author

Marked this FLIP as accepted.

@SeanRobb
Copy link

Lets close this Flip.

After discussion on the latest updates to Cadence 1.0 migrations the inspection logic is believed to have more false alarms then beneficial signal.

To avoid this fear and false alarm lets remove this from the plan to Mainnet.

@turbolent
Copy link
Member

@vishalchangrani @KshitijChaudhary666 Can this FLIP be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flip: governance Governance FLIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants