Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flow-go-sdk & cadence versions #779

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Jan 22, 2025

Relevant issue: onflow/flow-evm-gateway#727
Relevant PR: onflow/flow-evm-gateway#728

Description

Needed for some new subscription methods available on flow-go-sdk.
Also updates the breaking changes coming from the version bump on cadence, related to debugger.


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@bluesign
Copy link
Collaborator

Needed for some new subscription methods available on flow-go-sdk.

which ones? they may have been not implemented.

@m-Peter
Copy link
Contributor Author

m-Peter commented Jan 22, 2025

Needed for some new subscription methods available on flow-go-sdk.

which ones? they may have been not implemented.

@bluesign I know that they are not yet implemented by Emulator, I just need an Emulator version that uses [email protected]. which adds support for them 🙏 We need this for some building issue on the EVM Gateway, for a PoC that intends to utilize the SubscribeBlockHeadersFromStartHeight

@turbolent
Copy link
Member

Thank you for already starting to update the Cadence dependency!

This probably also needs to update flow-go. We have a tool in the Cadence repo which automatically updates all necessary dependencies at https://github.com/onflow/cadence/tree/master/tools/update. We can probably merge this PR for now, but might want to do a follow-up

@m-Peter
Copy link
Contributor Author

m-Peter commented Jan 22, 2025

Thank you for already starting to update the Cadence dependency!

This probably also needs to update flow-go. We have a tool in the Cadence repo which automatically updates all necessary dependencies at https://github.com/onflow/cadence/tree/master/tools/update. We can probably merge this PR for now, but might want to do a follow-up

That's a good point, but I am not sure as to which tag to use. The current is v0.38.0-preview.0.4, but the latest tag is v0.37.25 😅
Let's merge this for now, and I will follow up, once there's a proper tag of flow-go, to use.

@turbolent
Copy link
Member

flow-go is an exception in the typical tagging scheme of all repos in the org: it is only tagged for network updates, which happen very infrequently. So normally we use a latest commit of it when updating the downstream dependencies (i.e., all the developer tools)

@m-Peter
Copy link
Contributor Author

m-Peter commented Jan 22, 2025

flow-go is an exception in the typical tagging scheme of all repos in the org: it is only tagged for network updates, which happen very infrequently. So normally we use a latest commit of it when updating the downstream dependencies (i.e., all the developer tools)

Oh, you're totally right 😅 I completely forgot that I could do something like:

go get github.com/onflow/flow-go@92474d3

@turbolent Updated the flow-go version to the latest commit in 0c012fb

@joshuahannan
Copy link
Member

Is there anything blocking us from merging this? I could really use a new emulator release with the latest Cadence version

@m-Peter
Copy link
Contributor Author

m-Peter commented Jan 27, 2025

Is there anything blocking us from merging this? I could really use a new emulator release with the latest Cadence version

@joshuahannan Should be good to go, though I don't have merge rights 😅

@peterargue peterargue merged commit 085706c into onflow:master Jan 28, 2025
3 checks passed
@m-Peter m-Peter deleted the mpeter/bump-flow-go-sdk-version branch January 28, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants