fix batch bridge fee calculation, adding base fee for each NFT

onflow · Oct 26, 2024 · 8c3c54e · 8c3c54e
1 parent e122272
commit 8c3c54e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/cadence/transactions/bridge/nft/batch_bridge_nft_from_evm.cdc b/cadence/transactions/bridge/nft/batch_bridge_nft_from_evm.cdc
@@ -67,7 +67,7 @@ transaction(nftIdentifier: String, ids: [UInt256]) {
         // Set a cap on the withdrawable bridge fee
         var approxFee = FlowEVMBridgeUtils.calculateBridgeFee(
                 bytes: 200_000 // 200 kB as upper bound on movable storage used in a single transaction
-            )
+            ) + (FlowEVMBridgeConfig.baseFee * UFix64(ids.length))
         // Issue and store bridge-dedicated Provider Capability in storage if necessary
         if signer.storage.type(at: FlowEVMBridgeConfig.providerCapabilityStoragePath) == nil {
             let providerCap = signer.capabilities.storage.issue<auth(FungibleToken.Withdraw) &{FungibleToken.Provider}>(

diff --git a/cadence/transactions/bridge/nft/batch_bridge_nft_to_any_cadence_address.cdc b/cadence/transactions/bridge/nft/batch_bridge_nft_to_any_cadence_address.cdc
@@ -70,7 +70,7 @@ transaction(nftIdentifier: String, ids: [UInt256], recipient: Address) {
         // Set a cap on the withdrawable bridge fee
         var approxFee = FlowEVMBridgeUtils.calculateBridgeFee(
                 bytes: 200_000 // 200 kB as upper bound on movable storage used in a single transaction
-            )
+            ) + (FlowEVMBridgeConfig.baseFee * UFix64(ids.length))
         // Issue and store bridge-dedicated Provider Capability in storage if necessary
         if signer.storage.type(at: FlowEVMBridgeConfig.providerCapabilityStoragePath) == nil {
             let providerCap = signer.capabilities.storage.issue<auth(FungibleToken.Withdraw) &{FungibleToken.Provider}>(

diff --git a/cadence/transactions/bridge/nft/batch_bridge_nft_to_any_evm_address.cdc b/cadence/transactions/bridge/nft/batch_bridge_nft_to_any_evm_address.cdc
@@ -63,7 +63,7 @@ transaction(nftIdentifier: String, ids: [UInt64], recipient: String) {
         // Withdraw the requested NFT & set a cap on the withdrawable bridge fee
         var approxFee = FlowEVMBridgeUtils.calculateBridgeFee(
                 bytes: 200_000 // 200 kB as upper bound on movable storage used in a single transaction
-            )
+            ) + (FlowEVMBridgeConfig.baseFee * UFix64(ids.length))
         // Determine if the NFT requires onboarding - this impacts the fee required
         self.requiresOnboarding = FlowEVMBridge.typeRequiresOnboarding(self.nftType)
             ?? panic("Bridge does not support this asset type")

diff --git a/cadence/transactions/bridge/nft/batch_bridge_nft_to_evm.cdc b/cadence/transactions/bridge/nft/batch_bridge_nft_to_evm.cdc
@@ -62,14 +62,15 @@ transaction(nftIdentifier: String, ids: [UInt64]) {
         // Withdraw the requested NFT & set a cap on the withdrawable bridge fee
         var approxFee = FlowEVMBridgeUtils.calculateBridgeFee(
                 bytes: 200_000 // 200 kB as upper bound on movable storage used in a single transaction
-            )
+            ) + (FlowEVMBridgeConfig.baseFee * UFix64(ids.length))
         // Determine if the NFT requires onboarding - this impacts the fee required
         self.requiresOnboarding = FlowEVMBridge.typeRequiresOnboarding(self.nftType)
             ?? panic("Bridge does not support this asset type")
         // Add the onboarding fee if onboarding is necessary
         if self.requiresOnboarding {
             approxFee = approxFee + FlowEVMBridgeConfig.onboardFee
         }
+        log(approxFee)
 
         /* --- Configure a ScopedFTProvider --- */
         //