Merge pull request #58 from onflow/remove-redundant-normalization-ste…

…p-from-ci Remove redundant normalization step from CI
onflow · Apr 30, 2024 · 8d023e1 · 8d023e1
2 parents 986c5cc + 51f0440
commit 8d023e1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/.github/workflows/cadence_test.yml b/.github/workflows/cadence_test.yml
@@ -26,8 +26,6 @@ jobs:
         run: echo "/root/.local/bin" >> $GITHUB_PATH
       - name: Run tests
         run: sh local/run_cadence_tests.sh
-      - name: Normalize coverage report filepaths
-        run: sh ./local/normalize_coverage_report.sh
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v3
         env:

diff --git a/cadence/tests/flow_evm_bridge_tests.cdc b/cadence/tests/flow_evm_bridge_tests.cdc
@@ -502,7 +502,8 @@ fun testOnboardAndBridgeNFTToEVMSucceeds() {
         contractAddr: exampleNFTAccount.address,
         contractName: "ExampleNFT",
         nftID: aliceID,
-        bridgeAccountAddr: bridgeAccount.address
+        bridgeAccountAddr: bridgeAccount.address,
+        beFailed: false
     )
 
     requiresOnboarding = typeRequiresOnboardingByIdentifier(exampleNFTIdentifier)

diff --git a/local/normalize_coverage_report.sh b/local/normalize_coverage_report.sh