Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut down on redundant code #47

Closed
sisyphusSmiling opened this issue Apr 24, 2024 · 0 comments · Fixed by #48
Closed

Cut down on redundant code #47

sisyphusSmiling opened this issue Apr 24, 2024 · 0 comments · Fixed by #48
Labels
EVM Feedback Improvement

Comments

@sisyphusSmiling
Copy link
Contributor

Issue To Be Solved

Currently, bridge methods share a lot of code and the functions are very long. This is increased by the introduction of #46.

Suggest A Solution

Add util methods that cover shared code functionality and leverage these methods to reduce boilerplate.
@sisyphusSmiling sisyphusSmiling moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in FlowEVM Bridge Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready for Pickup to ✅ Done in 🌊 Flow 4D Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EVM Feedback Improvement
Projects
FlowEVM Bridge
Status: Done
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate bridging logic onflow/flow-evm-bridge
1 participant
@sisyphusSmiling