-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate bridging logic #48
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-special-case-handler #48 +/- ##
============================================================
- Coverage 85.47% 84.90% -0.57%
============================================================
Files 18 18
Lines 819 828 +9
============================================================
+ Hits 700 703 +3
- Misses 119 125 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a few small comments
Co-authored-by: Joshua Hannan <[email protected]>
Feel free to merge this to |
Closes: #47
Stacked on: #46
Description
Consolidates redundant code between
FlowEVMBridge
andFlowEVMBridgeHandlers
related to fungible token bridging. Also adds helper methods inFlowEVMBridgeUtils
to simplify the logic in the core bridge contract. Comments were added to further enhance readability.For contributor use:
master
branchFiles changed
in the Github PR explorer