Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display type serialization #131

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Oct 22, 2024

Continues: #128


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (02aab3f) to head (4a11fd2).
Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
cadence/contracts/utils/SerializeMetadata.cdc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   86.19%   86.70%   +0.50%     
==========================================
  Files          18       18              
  Lines         884      970      +86     
==========================================
+ Hits          762      841      +79     
- Misses        122      129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling self-assigned this Oct 22, 2024
@sisyphusSmiling sisyphusSmiling force-pushed the gio/update_display_type branch from ec9fa3a to 6f57cf5 Compare October 23, 2024 00:01
@sisyphusSmiling sisyphusSmiling changed the title Gio/update display type Update display type serialization Oct 23, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review October 23, 2024 00:06
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner October 23, 2024 00:06
@franklywatson franklywatson merged commit a452f91 into main Oct 23, 2024
2 checks passed
@franklywatson franklywatson deleted the gio/update_display_type branch October 23, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants