Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fee estimate #133

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Update fee estimate #133

merged 12 commits into from
Oct 29, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Oct 25, 2024

Closes: #125

Description

  • Updates bridge fee estimation, setting a withdrawable upper bound on the ScopedFTProvider based on the upper bound of bytes we would expect to move in a single transaction <- credit to @bluesign for the idea & consult

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Oct 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (02aab3f) to head (d043d98).
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   86.19%   86.73%   +0.53%     
==========================================
  Files          18       18              
  Lines         884      965      +81     
==========================================
+ Hits          762      837      +75     
- Misses        122      128       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling changed the title Gio/update fee estimate Update fee estimate Oct 25, 2024
@sisyphusSmiling sisyphusSmiling force-pushed the gio/update-fee-estimate branch from fba9e24 to e122272 Compare October 25, 2024 21:23
@sisyphusSmiling sisyphusSmiling force-pushed the gio/update-fee-estimate branch from 0ac49f6 to 9c6c01f Compare October 26, 2024 04:44
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review October 28, 2024 21:05
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner October 28, 2024 21:05
@sisyphusSmiling sisyphusSmiling merged commit 1ca51a6 into main Oct 29, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/update-fee-estimate branch October 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

If the storage.used increasing during the withdraw, the bridging transaction will be broken.
3 participants