Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing aliases in flow.json config file and update tests #21

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Mar 20, 2024

Closes: #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter m-Peter requested a review from a team as a code owner March 20, 2024 16:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (add-bridge-tests@cd204d3). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             add-bridge-tests      #21   +/-   ##
===================================================
  Coverage                    ?   80.72%           
===================================================
  Files                       ?        3           
  Lines                       ?      166           
  Branches                    ?        0           
===================================================
  Hits                        ?      134           
  Misses                      ?       32           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the help, thanks for the PR! 🙏

@sisyphusSmiling sisyphusSmiling merged commit 930e741 into onflow:add-bridge-tests Mar 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants