Batch onboarding scripts & txns #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 82.82% 82.88% +0.05%
==========================================
Files 18 18
Lines 827 818 -9
==========================================
- Hits 685 678 -7
+ Misses 142 140 -2 ☔ View full report in Codecov by Sentry. |
joshuahannan
approved these changes
Apr 16, 2024
Comment on lines
+13
to
+15
| if results[type] != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Probably not, but covering a case where there are non-unique values in the provided array
… for batch onboarding
sisyphusSmiling
force-pushed
the
batch-scripts
branch
from
b96e5bd to
428634e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #33 #34
Description
Adds support for batch operations.
For contributor use:
masterbranchFiles changedin the Github PR explorer