Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SerializeNFT to SerializeMetadata #36

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 16, 2024

Closes: #30


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Apr 16, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 16, 2024 20:46
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 16, 2024 20:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@3a8d955). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage        ?   82.82%           
=======================================
  Files           ?       18           
  Lines           ?      827           
  Branches        ?        0           
=======================================
  Hits            ?      685           
  Misses          ?      142           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit d83c278 into main Apr 16, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the restructure-repo branch April 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Rename SerializeNFT to SerializeMetadata
3 participants