Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previewnet deployment details #37

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 17, 2024

Closes: #9

Description

Adds Previewnet deployment details to flow.json along with supporting templates & deployment args. Previewnet deployment currently only supports onboarding. Once EVM contract updates are reviewed (relevant PR: onflow/flow-go#5677), merged and changes updated on PN, bridge functionality will be enabled end-to-end through the COA resource.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Apr 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (428634e) to head (a820914).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   82.88%   82.82%   -0.06%     
==========================================
  Files          18       19       +1     
  Lines         818      827       +9     
==========================================
+ Hits          678      685       +7     
- Misses        140      142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 17, 2024 00:36
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 17, 2024 00:36
@sisyphusSmiling sisyphusSmiling merged commit 8dce25e into main Apr 17, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the previewnet-deployment branch April 17, 2024 17:29
@sisyphusSmiling sisyphusSmiling added Deployment Requires contract deployment or update EVM labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Requires contract deployment or update EVM
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Deploy bridge contracts to Previewnet
3 participants