Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to EVM interface #39

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Updates to EVM interface #39

merged 7 commits into from
Apr 24, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 17, 2024

Closes: #38

Description

Updates EVM interface based on feedback received in onflow/flow-go#5677


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (428634e) to head (b69b907).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   82.88%   84.49%   +1.60%     
==========================================
  Files          18       16       -2     
  Lines         818      703     -115     
==========================================
- Hits          678      594      -84     
+ Misses        140      109      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 23, 2024 16:05
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 23, 2024 16:05
Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2G

@sisyphusSmiling sisyphusSmiling merged commit 2e0ae6a into main Apr 24, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the evm-updates branch April 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update EVM contract interface
3 participants