Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable onboard + bridge in single transaction for Cadence -> EVM path #44

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 19, 2024

Closes: #43

As mentioned in #43, due to limitations in Cadence contract deployments that break bridge request atomicity, we can only support onboard & bridge transactions for the Cadence to EVM path. If the Cadence runtime at some point in the future allows for contracts to be available in the runtime within the same transaction they're deployed, we should be able to make similar changes to supporting transactions without the need to alter contract code.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (428634e) to head (7dc7ef6).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   82.88%   85.47%   +2.58%     
==========================================
  Files          18       18              
  Lines         818      819       +1     
==========================================
+ Hits          678      700      +22     
+ Misses        140      119      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 19, 2024 21:25
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 19, 2024 21:25
@sisyphusSmiling sisyphusSmiling merged commit 986c5cc into main Apr 29, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the onboard-and-bridge-to-evm branch April 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add support for onboard + bridge where possible
3 participants