Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFix64 <-> UInt256 conversion fix and init test coverage #57

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 30, 2024

Closes: #56

Description

Fixes UFix64 <-> UInt256 conversion bug that simply truncated decimal values and adds test coverage for the util functionality.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling changed the title Conversion coverage UFix64 <-> UInt256 conversion fix and init test coverage Apr 30, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 30, 2024 01:03
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 30, 2024 01:03
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.89%. Comparing base (428634e) to head (ebb0683).
Report is 72 commits behind head on main.

Files Patch % Lines
cadence/contracts/bridge/FlowEVMBridgeUtils.cdc 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   82.88%   85.89%   +3.00%     
==========================================
  Files          18       19       +1     
  Lines         818      886      +68     
==========================================
+ Hits          678      761      +83     
+ Misses        140      125      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit d98a19e into main Apr 30, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the conversion-coverage branch April 30, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix UFix64 <-> UInt256 conversion
3 participants