Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EVMUtils & implementations #84

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Remove EVMUtils & implementations #84

merged 2 commits into from
Jun 17, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jun 13, 2024

Closes: #78

Description

Refactors EVMUtils EVMAddress de/serialization in favor of new EVM methods.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Jun 13, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review June 13, 2024 23:22
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner June 13, 2024 23:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.12%. Comparing base (02aab3f) to head (2a60d7e).
Report is 10 commits behind head on main.

Files Patch % Lines
cadence/contracts/bridge/FlowEVMBridgeConfig.cdc 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   86.19%   86.12%   -0.08%     
==========================================
  Files          18       17       -1     
  Lines         884      879       -5     
==========================================
- Hits          762      757       -5     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit a50fdd6 into main Jun 17, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the remove-evm-utils branch June 17, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove EVMUtils contract
3 participants