Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit followup #87

Closed
wants to merge 30 commits into from
Closed

Audit followup #87

wants to merge 30 commits into from

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jun 19, 2024

Closes: #74 #75 #79

Description

Audit ID                Update Commit Notes
FLB-1 N/A Acknowledged
FLB-2 a7e0f6f Corrected
FLB-3 a9fbaff Corrected
FLB-4 cf92c05 Corrected
FLB-5 1407213 Corrected
FLB-6 N/A Acknowledged
FLB-7.1 6136d31 Corrected
FLB-7.2 N/A Acknowledged
FLB-7.3.a N/A Acknowledged
FLB-7.3.b 7985c1d Corrected
FLB-7.4 331fa9d Corrected
FLB-8 N/A Acknowledged
FLB-9 209e8ae Corrected
FLB-10 4290e78 Removed renunciation, retained transfer
FLB-11.1.a N/A Clarification
FLB-11.1.b dfd4ea3 Corrected
FLB-11.2 N/A From what can be gathered against the EIP 721 spec and OpenZeppelin standards, all ERC721 contracts must also implement ERC165
FLB-11.3 N/A Acknowledged
FLB-12 4e8a29e Corrected
FLB-13 197f523, c61f5b4, 46c6cc7 Corrected
FLB-14 5afdabd Corrected
FLB-15 e43bf58 Corrected
FLB-16 15d7672 Corrected (where possible & not redundant)
FLB-17 52232cb Corrected
FLB-18 N/A Clarification
FLB-19 N/A Clarification
FLB-20 faa548e Added typ-level pausing
FLB-21 N/A Clarification
FLB-22 5baa471 Corrected all except FLB-22.3 - skipping non-serializable traits is expected behavior in the interest of returning a value containing at least that which can be serialized.

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling requested a review from m-Peter June 20, 2024 22:24
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review June 20, 2024 22:24
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner June 20, 2024 22:24
@sisyphusSmiling
Copy link
Contributor Author

Closing in favor of another branch that matches auditors requirements for follow up

@sisyphusSmiling sisyphusSmiling mentioned this pull request Jun 21, 2024
6 tasks
@sisyphusSmiling sisyphusSmiling deleted the audit-followup branch September 19, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update .sol templates
1 participant