Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish bridge contract events for traceability & readability #89

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jun 24, 2024

Closes: #65

Description

Updates bridge events to include values common in NFT & FT standards which enhance asset traceability. Also moving from emitting Cadence Type values to more human-readable type identifier strings.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (02aab3f) to head (700dfe4).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   86.19%   86.64%   +0.44%     
==========================================
  Files          18       17       -1     
  Lines         884      921      +37     
==========================================
+ Hits          762      798      +36     
- Misses        122      123       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling requested a review from ramtinms June 24, 2024 22:17
@sisyphusSmiling
Copy link
Contributor Author

cc @bjartek

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review June 24, 2024 22:17
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner June 24, 2024 22:17
@sisyphusSmiling sisyphusSmiling self-assigned this Jun 24, 2024
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if Bjarte is okay with it!

@bjartek
Copy link
Contributor

bjartek commented Jun 25, 2024

Yeah this works!

@sisyphusSmiling
Copy link
Contributor Author

Added some minor changes added in 700dfe4 - changing from event type Type to string and adding uuid where traceability is relevant.

@sisyphusSmiling sisyphusSmiling merged commit 01691c9 into main Jun 25, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the update-bridge-events branch June 25, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Enhance bridging events
5 participants