-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish bridge contract events for traceability & readability #89
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 86.19% 86.64% +0.44%
==========================================
Files 18 17 -1
Lines 884 921 +37
==========================================
+ Hits 762 798 +36
- Misses 122 123 +1 ☔ View full report in Codecov by Sentry. |
cc @bjartek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me if Bjarte is okay with it!
Yeah this works! |
Added some minor changes added in 700dfe4 - changing from event type |
Closes: #65
Description
Updates bridge events to include values common in NFT & FT standards which enhance asset traceability. Also moving from emitting Cadence Type values to more human-readable type identifier strings.
For contributor use:
main
branchFiles changed
in the Github PR explorer