Merge pull request #242 from m-Peter/improve-eth-call-error-logging

Improve error logging for `eth_call` JSON-RPC endpoint
onflow · May 13, 2024 · 4cd2076 · 4cd2076
2 parents 553fca6 + abbe267
commit 4cd2076
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/api/api.go b/api/api.go
@@ -423,8 +423,8 @@ func (b *BlockChainAPI) Call(
 
 	res, err := b.evm.Call(ctx, tx, from, cadenceHeight)
 	if err != nil {
-		b.logger.Error().Err(err).Msg("failed to execute call")
-		return handleError[hexutil.Bytes](b.logger, errs.ErrInternal)
+		b.logger.Debug().Err(err).Msg("failed to execute call")
+		return nil, err
 	}
 
 	return res, nil

diff --git a/services/requester/requester.go b/services/requester/requester.go
@@ -323,6 +323,10 @@ func (e *EVM) Call(
 	from common.Address,
 	height uint64,
 ) ([]byte, error) {
+	e.logger.Debug().
+		Str("data", fmt.Sprintf("%x", data)).
+		Msg("call")
+
 	hexEncodedTx, err := cadence.NewString(hex.EncodeToString(data))
 	if err != nil {
 		return nil, err
@@ -333,10 +337,6 @@ func (e *EVM) Call(
 		return nil, err
 	}
 
-	e.logger.Debug().
-		Str("data", fmt.Sprintf("%x", data)).
-		Msg("call")
-
 	scriptResult, err := e.executeScriptAtHeight(
 		ctx,
 		dryRunScript,