Use instance of config instead of reference #681
Merged
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
requested review from
peterargue,
m-Peter and
zhangchiqing
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
m-Peter
reviewed
Nov 27, 2024
bootstrap/bootstrap.go
Outdated
| @@ -185,7 +185,7 @@ func (b *Bootstrap) StartAPIServer(ctx context.Context) error { | |||
| b.server = api.NewServer(b.logger, b.collector, b.config) | |||
|
|
|||
| // create the signer based on either a single coa key being provided and using a simple in-memory | |||
| // signer, or multiple keys being provided and using signer with key-rotation mechanism. | |||
| // signer, or multiple keys being provided and using signer with key-rotation mechanism.bootstrap/bootstrap.go | |||
There was a problem hiding this comment.
Suggested change
| // signer, or multiple keys being provided and using signer with key-rotation mechanism.bootstrap/bootstrap.go | |
| // signer, or multiple keys being provided and using signer with key-rotation mechanism. |
m-Peter
approved these changes
Nov 27, 2024
peterargue
approved these changes
Nov 27, 2024
janezpodhostnik
force-pushed
the
janez/config-instance
branch
from
1d626c7 to
a2386c1
Compare
janezpodhostnik
merged commit 22b6d46
into
janez/switch-to-flow-go-metrics-server
2 checks passed
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMO its safer to use an instance so we don't get strange behavior if something accidentally changes the config. It also doesn't need to be a reference since it is not expected to be modified.
For contributor use:
masterbranchFiles changedin the Github PR explorer