Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: V2 FungibleToken Standard #77
WIP: V2 FungibleToken Standard #77
Changes from 2 commits
e7f717c
db9cc2d
1718595
03527c0
5bf65e5
61d4243
b39028c
1bb20b6
1ae18bf
7a102a8
32c0010
093318d
079d367
13b5b0d
fccd93c
ba9bf2e
a6fdcb7
90395f4
f461448
ecc811e
306a1fe
ead9c82
e8b7f56
58c157b
c70204c
7aee404
51bfed4
1933db4
8d70279
8c4a3c4
089b9fb
7545b02
4e5f87d
a0d375b
1082bac
0aadea8
5b06fd7
21203f2
5e2328d
84880ef
eb5637a
e6de7ef
ad86e87
81b0e9e
b58c49d
a31fd46
541764b
f24f5f2
50f777c
24763ca
c5fd8b5
54b8066
abe2080
2045a1d
1f32f2e
e70eaaf
b924625
c742c6d
051b966
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way the FungibleToken interface itself can enforce that this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that I am aware of. @turbolent do you know if it would be possible to implement post conditions for destructors in a resource interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put there something like:
if self.balance>0
99% of the cases it is 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would that accomplish @bluesign ? Maybe I am misunderstanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flow still thinks registers are updated even update is no-op.
For example, currently FlowToken spams this on every block. ( FlowToken.totalSupply as changed ) Actually it is a bit Flow-go problem. But it is good to not even write something, when it is not changed I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, that is a good point. I'll change that. That could be changed in the current example contract and flowtoken too