Use CCF encoding when requesting events from AccessAPI #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
requested review from
janezpodhostnik,
sideninja,
chasefleming and
nvdtf
as code owners
koko1123
approved these changes
Oct 31, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 61.23% 61.25% +0.01%
==========================================
Files 26 26
Lines 3312 3324 +12
==========================================
+ Hits 2028 2036 +8
- Misses 1112 1115 +3
- Partials 172 173 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
I tried this out against the mainnet today after the spork and seems to be working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #500
Description
The AccessAPI recently added support for specifying the encoding for events returned in the request. CCF encoding is significantly more compact and includes additional information that can't be included in JSON-CDC format.
This PR updates all gRPC calls to endpoints that support CCF encoding to use the new format, and handles conversion to the original cadence object. The change should be transparent to the caller, except that less data is transported over the web.
For contributor use:
masterbranchFiles changedin the Github PR explorer