Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send and subscribe transaction statuses endpoint #772

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #745

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.00%. Comparing base (7b58582) to head (0a99ee4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 67.50% 9 Missing and 4 partials ⚠️
access/grpc/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   52.92%   54.00%   +1.08%     
==========================================
  Files          35       35              
  Lines        5580     5709     +129     
==========================================
+ Hits         2953     3083     +130     
+ Misses       2231     2199      -32     
- Partials      396      427      +31     
Flag Coverage Δ
unittests 54.00% <64.28%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

access/grpc/grpc.go Outdated Show resolved Hide resolved
access/grpc/grpc.go Outdated Show resolved Hide resolved
defer close(txStatusChan)
defer close(errChan)

messageIndex := uint64(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this nextIndex to it's clear what's stored

Suggested change
messageIndex := uint64(0)
nextIndex := uint64(0)

@peterargue peterargue merged commit 16ec51b into onflow:master Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SendAndSubscribeTransactionStatuses endpoint
4 participants