Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align block header with protobuf schema #778

Conversation

illia-malachyn
Copy link
Contributor

Closes: #765

test/entities.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 24 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (3ae9ebc) to head (9f84549).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 76.00% 16 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   56.65%   57.04%   +0.39%     
==========================================
  Files          35       35              
  Lines        7269     7391     +122     
==========================================
+ Hits         4118     4216      +98     
- Misses       2657     2673      +16     
- Partials      494      502       +8     
Flag Coverage Δ
unittests 57.04% <81.81%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franklywatson franklywatson merged commit 6ab9085 into onflow:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockHeader response object is different in sdk and flow/protobuf
5 participants