-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cadence 1.0] Improve migrations #5533
[Cadence 1.0] Improve migrations #5533
Conversation
|
||
// NewContractsExtractionMigration returns a migration that extracts the code for contracts from the payloads. | ||
// The given contracts map must be allocated, and gets populated with the code for the contracts found in the payloads. | ||
func NewContractsExtractionMigration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! 👌
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5533 +/- ##
==========================================================
- Coverage 55.97% 55.92% -0.06%
==========================================================
Files 1045 1047 +2
Lines 102968 103037 +69
==========================================================
- Hits 57639 57624 -15
- Misses 40936 41024 +88
+ Partials 4393 4389 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MetadataViews.ResolverCollection needs to get converted to ViewResolver.ResolverCollection
Depends on #5539
Work towards onflow/cadence#3162