[EVM] Add bridging interface to EVM contract - stable cadence port

[janezpodhostnik]

original PR: #5677

[sisyphusSmiling]

Looks like I'm still getting errors in bootstrap_test.go on expectedStateCommitment. @janezpodhostnik @ramtinms Would the updates to the EVM contract affect the genesis state commitment or do you think this issue is unrelated to the changes here?

[janezpodhostnik]

Yes, the changes are expected due to the hash of the contract changing.

The test have to be adjusted to use the new state commitment.

[sisyphusSmiling]

Ah makes sense. How do I generate the new hash? I guess I could just copy the new actual, but that feels like it's not best practice

Update: Based on this Discord thread, I updated the state commitments on the new actual.

[turbolent]

Is this separate PR needed? Once the feature landed on master (#5677 got merged), the usual sync of master into the Cadence 1.0 feature branch will bring it along anyways.

Happy to already merge it, more a note that in the future, we could save effort here.

[sisyphusSmiling]

@turbolent I'm not certain as I'm not familiar with the processes to manage flow-go. What would you suggest here? I don't want this PR to create conflicts down the road.

[sideninja]

Is this separate PR needed? Once the feature landed on master (#5677 got merged), the usual sync of master into the Cadence 1.0 feature branch will bring it along anyways.

Happy to already merge it, more a note that in the future, we could save effort here.

I agree, in the future is more clear to merge master. Also to do it regularly since the last time I was doing it after quite some time it was a bit painful.

[turbolent]

#5767 is currently bringing this to feature/stable-cadence. Once it landed, we can update this branch and there shouldn't be really anything left

[janezpodhostnik]

I update the PR and there are some things that are missing on stable cadence branch. @sisyphusSmiling can you check if we want to merge this (I think we do)

[sisyphusSmiling]

@janezpodhostnik the contents look correct to me and CI is mostly passing with the exception of engine/execution unit tests

[janezpodhostnik]

Should be good now

[turbolent]

Nice!

[turbolent]

Suggested change

	EVM.borrowBridgeAccessor().depositTokens(vault: <-vault, to: self.address(), feeProvider: feeProvider)
	EVM.borrowBridgeAccessor().depositTokens(
	vault: <-vault,
	to: self.address(),
	feeProvider: feeProvider
	)