Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atree Inlining & Deduplication with Cadence v0.42 #5736

Conversation

fxamacker
Copy link
Member

This PR is to be used for building migration program needed by spork and running benchmarks.

This enables Atree Inlining & Deduplication with Cadence 0.42 in flow-go (e.g. atree migration program, etc.).

PR #5349 (in fxamacker branch) will be closed and we will start using this PR in a feature branch to build migration program.

@fxamacker fxamacker added the enhancement New feature or request label Apr 18, 2024
@fxamacker fxamacker requested a review from turbolent April 18, 2024 21:48
@fxamacker fxamacker self-assigned this Apr 18, 2024
@fxamacker fxamacker requested review from a team April 18, 2024 22:10
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just one comment regarding the Cadence version. We can also do that in another PR if you want

go.mod Outdated Show resolved Hide resolved
Base automatically changed from fxamacker/sync-feature-branch-atree-inlining-cadence-v0.42 to feature/atree-inlining-cadence-v0.42 April 19, 2024 02:48
…d-atree-inlining-to-feature-branch-atree-inlining-cadence-v0.42
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question re: the TODO

fvm/evm/emulator/state/collection.go Outdated Show resolved Hide resolved
…d-atree-inlining-to-feature-branch-atree-inlining-cadence-v0.42
@turbolent
Copy link
Member

CI seems to fail because of flaky tests, can probably ignore those

@turbolent
Copy link
Member

turbolent commented Apr 19, 2024

I think the branch protection rules are broken again and so the CI check list requires checks that no longer exist/got renamed. Force merging, it's into a feature branch anyway

@turbolent turbolent merged commit df3c091 into feature/atree-inlining-cadence-v0.42 Apr 19, 2024
55 checks passed
@turbolent turbolent deleted the fxamacker/add-atree-inlining-to-feature-branch-atree-inlining-cadence-v0.42 branch April 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants