-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Add increment method for monotonous counter #5814
[Access] Add increment method for monotonous counter #5814
Conversation
c6b01e6
to
7623fa8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5814 +/- ##
==========================================
- Coverage 55.65% 55.64% -0.02%
==========================================
Files 1134 1134
Lines 89636 89638 +2
==========================================
- Hits 49890 49882 -8
- Misses 34956 34968 +12
+ Partials 4790 4788 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7623fa8
to
805dd74
Compare
bfbaf3c
to
c42cf78
Compare
It looks like the Access Cohort3 Integration Test is flaky. I've checked other PRs and see it fails regardless of the changes. Update: |
c42cf78
to
a942080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some godoc is missing but otherwise all good.
a942080
to
c7af499
Compare
c7af499
to
db60345
Compare
Add increment method for monotonous counter.
Relates to onflow/flow#1458
Link to issue #5674