Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add increment method for monotonous counter #5814

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Apr 30, 2024

Add increment method for monotonous counter.

Relates to onflow/flow#1458
Link to issue #5674

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch from c6b01e6 to 7623fa8 Compare April 30, 2024 12:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.64%. Comparing base (e4bdb7e) to head (db60345).

Files Patch % Lines
engine/access/state_stream/backend/handler.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
- Coverage   55.65%   55.64%   -0.02%     
==========================================
  Files        1134     1134              
  Lines       89636    89638       +2     
==========================================
- Hits        49890    49882       -8     
- Misses      34956    34968      +12     
+ Partials     4790     4788       -2     
Flag Coverage Δ
unittests 55.64% <87.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch from 7623fa8 to 805dd74 Compare April 30, 2024 13:04
@illia-malachyn illia-malachyn changed the title Add increment method for monotonous counter [Access] Add increment method for monotonous counter Apr 30, 2024
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch 2 times, most recently from bfbaf3c to c42cf78 Compare May 1, 2024 14:22
@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented May 1, 2024

It looks like the Access Cohort3 Integration Test is flaky. I've checked other PRs and see it fails regardless of the changes.
The test fails during assertion1 assertion2. The expected value is 10, actual - varies from the run to run.

Update:
The test unexpectedly passed after many retries. I'm pretty sure there's something weird going on. It is reproducible locally.
@peterargue Did you notice such a behavior before?

access/handler.go Outdated Show resolved Hide resolved
module/counters/monotonous_counter_test.go Show resolved Hide resolved
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch from c42cf78 to a942080 Compare May 2, 2024 10:55
@peterargue peterargue requested a review from durkmurder May 6, 2024 22:02
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some godoc is missing but otherwise all good.

module/counters/monotonous_counter.go Show resolved Hide resolved
module/counters/monotonous_counter_test.go Show resolved Hide resolved
module/counters/monotonous_counter_test.go Show resolved Hide resolved
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch from a942080 to c7af499 Compare May 10, 2024 09:42
go.mod Outdated Show resolved Hide resolved
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch from c7af499 to db60345 Compare May 13, 2024 10:37
@Guitarheroua Guitarheroua added this pull request to the merge queue May 13, 2024
Merged via the queue into onflow:master with commit 4c712e5 May 13, 2024
55 checks passed
@Guitarheroua Guitarheroua deleted the illia-malachyn/5674-add-inc-method-to-monotonous-counter branch May 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants