-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Add REST endpoint to get an accounts flow balance #6253
[Access] Add REST endpoint to get an accounts flow balance #6253
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6253 +/- ##
==========================================
- Coverage 41.55% 41.55% -0.01%
==========================================
Files 1993 1995 +2
Lines 141665 141724 +59
==========================================
+ Hits 58868 58888 +20
- Misses 76667 76705 +38
- Partials 6130 6131 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, has couple comments to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. added a couple small comments
…riiDiachuk/flow-go into add-rest-endpoint-GetAccountsBalance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after adding the test, I think this is ready to go
…riiDiachuk/flow-go into add-rest-endpoint-GetAccountsBalance
In this PR a new REST endpoint was added that returns the account's flow balance using the new GetAccountBalance method in the backend.
Closes: #6001
Related PR: onflow/flow#1491