-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FVM] Recover NFT contract #6388
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6388 +/- ##
==========================================
- Coverage 41.51% 41.49% -0.03%
==========================================
Files 2013 2013
Lines 143518 143577 +59
==========================================
- Hits 59577 59572 -5
- Misses 77761 77830 +69
+ Partials 6180 6175 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Supun Setunga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Recovered Contract" the best name for it? I worry that developers who are unaware of this will be confused by the error messages. Maybe we just need to update the error messages to have more detail, like, "{Contract Name} is no longer functional. A version of the contract has been recovered to allow access to a small subset of functionality. isAvailableToWithdraw is not available in recovered program."
@joshuahannan Great idea! I tried to improve the error messages in 2844c97 @SupunS PTAL: I realized there was a bug when printing the errors from the panics and opened onflow/cadence#3548. I also refactored the "finalize and merge" of the changes in the migration in 2844c97 (introduces the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I haven't check too much, but collection seems missing, I think adding also collection is important (with ownedNFTs) |
@bluesign right, that's planned to be added next |
Work towards onflow/cadence#3480
Add support for recovering contracts conforming to the pre-Cadence 1.0 NFT standard.