Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ErrorMessageWithRevertReason when validating replay of EVM tx #6952

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Jan 29, 2025

Closes: #6951
Follow up on: #6770

The errorMessage field of EVM.TransactionExecuted event, now has a more human-friendly representation.
So we need to use the ErrorMessageWithRevertReason when validating the execution replay of an EVM tx.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.07%. Comparing base (c8240d3) to head (d9eab95).

Files with missing lines Patch % Lines
fvm/evm/offchain/sync/replay.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
- Coverage   41.08%   41.07%   -0.01%     
==========================================
  Files        2120     2120              
  Lines      186100   186100              
==========================================
- Hits        76450    76446       -4     
+ Misses     103243   103242       -1     
- Partials     6407     6412       +5     
Flag Coverage Δ
unittests 41.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1010001 j1010001 requested a review from peterargue January 29, 2025 22:43
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit c740ce3 Jan 30, 2025
56 checks passed
@janezpodhostnik janezpodhostnik deleted the mpeter/fix-evm-tx-replay-err-msg-validation branch January 30, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] Update replayer logic to validate txs with new error message format
5 participants