Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Add flag to backward compatibilities testing tool to continue verify when mismatching is found #6954

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangchiqing
Copy link
Member

The current backward compatibilities testing tool (verify execution result) will stop as soon as it found a mismatch. This PR adds a flag to control that and by default it will not stop but continue verifying.

@zhangchiqing zhangchiqing requested a review from j1010001 January 29, 2025 18:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 41.08%. Comparing base (c8240d3) to head (a54d636).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/util/cmd/verify_execution_result/cmd.go 0.00% 7 Missing ⚠️
engine/verification/verifier/verifiers.go 12.50% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6954   +/-   ##
=======================================
  Coverage   41.08%   41.08%           
=======================================
  Files        2120     2120           
  Lines      186100   186107    +7     
=======================================
+ Hits        76450    76457    +7     
+ Misses     103243   103242    -1     
- Partials     6407     6408    +1     
Flag Coverage Δ
unittests 41.08% <6.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing force-pushed the leo/add-stop-on-match-flag branch from 7797ac8 to a54d636 Compare January 29, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants