Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize NFT transactions and scripts #210

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Apr 3, 2024

Description

  • Renames tests to end with _test.cdc
  • Reorganize scripts into folders within the transactions/ directory and keep scripts that are purely for tests in the tests/ directory
  • Fix a few metadata tests

I'm planning on going through the docs site and cadence-lang.org to make sure all the links to these moved transactions and scripts are fixed

I mostly want to know if we think it is a bad idea to change all these paths since it might break links or dependencies in the ecosystem that link to these scripts. It would be nice to standardize them though so we can have a unified structure among all our repos

@joshuahannan joshuahannan changed the title Reorganize transactions and scripts Reorganize NFT transactions and scripts Apr 3, 2024
@joshuahannan
Copy link
Member Author

I only found one link across the onflow/docs repo and cadence-lang.org repo that needed to be updated, so I make a PR for that: onflow/docs#712. It makes me feel better about the other updated links

@joshuahannan joshuahannan merged commit 808e6db into standard-v2 Apr 9, 2024
2 checks passed
@joshuahannan joshuahannan deleted the josh/reorg-txs branch April 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant