-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFT Storage Requirement to Collection and forEachID()
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks great, one thing i would add is a default implementation for
then you could remove the |
turbolent
reviewed
Apr 11, 2024
sisyphusSmiling
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FLIP
Based on this discussion in discord and this comment on the NFT standard PR, we have come to the conclusion that it probably makes sense to enforce how NFTs are stored for standardization and in this specific case, to allow projects to easily iterate through IDs in a collection that has many stored NFTs.
Enforcing the
ownedNFTs
field does not restrict projects who want to store their NFTs in unique ways because they can just ignore the field if they want, so having it for the 99% of projects who do and will follow it is very useful.For contributor use:
standard-v2
branchFiles changed
in the Github PR explorer