-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/executiondata proto pkg #1353
Fix/executiondata proto pkg #1353
Conversation
Hey this is a good idea because of the
I suggest making a PR in |
I think we should go ahead and make this change before the api is widely used. @treethought can you pull in master and regenerate the files? |
aab70c4
to
f636260
Compare
protobuf/README.md
Outdated
@@ -11,6 +11,7 @@ Check out the [Flow Access API specification](/docs/content/access-api.md). | |||
You can use [buf](https://github.com/bufbuild/buf) to generate gRPC client stubs in a variety of languages. | |||
Please make sure you have `protoc-gen-go-grpc` installed, for example using command | |||
```shell script | |||
go install google.golang.org/protobuf/cmd/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to making this change, but I think we should do it as a separate PR.
Are you able to generate the files using the existing setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had added that line for what I used since I couldn't find what version was being used, but just found via #905 (comment) that it seems to be set in the flow-go makefile as v1.3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok. thanks for fixing the docs!
8f1647c
to
822661b
Compare
FYI @nvdtf, @Guitarheroua |
Closes: #???
Description
Fixes the package name for executiondata protobuf file from access -> executiondata.
Related to #1275 and onflow/flow-go-sdk#378 and needed for onflow/flow-go-sdk#417
Previously, with package
access
, theexecutiondata
types could not be imported in generated go code.For contributor use:
master
branchFiles changed
in the Github PR explorer