-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cadence tests to latest API features #161
Conversation
cc @sisyphusSmiling @austinkline A sneak peek for the features of the next |
This is awesome @m-Peter! Thanks so much for starting the test updates, very helpful to see the new testing features in context |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 4 4
Lines 349 349
=======================================
Hits 293 293
Misses 56 56 ☔ View full report in Codecov by Sentry. |
@sisyphusSmiling Can you take a look at this please? 🙏 |
Sorry for the delay @m-Peter, will take a look today. Side note to myself to add a CODEOWNERS file to the repo so PRs get auto-assigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work (as always) on the testing API changes! Thank you for updating the tests here, it's very helpful to see the new API in action. Tests look much cleaner!
Just a couple small comments on test script naming, but not a blocker for merging at all, especially since they're test scripts.
Preliminary work to update the Cadence tests to the upcoming API features.
Most notable features include the ability to specify deployment addresses in
flow.json
config file, thus allowing developers to import the contracts under test, in their tests files. This allows the use of nested types defined in these contracts. E.g.:The above snippet allows performing assertions on events payload.