Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example transaction transferring child NFTs from parent account #177

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

sisyphusSmiling
Copy link
Collaborator

Closes: #176

@sisyphusSmiling sisyphusSmiling added the enhancement New feature or request label Nov 16, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Nov 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (3d58af2) to head (30b56bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           4        4           
  Lines         364      364           
=======================================
  Hits          333      333           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sisyphusSmiling sisyphusSmiling requested review from austinkline, nvdtf and a team November 16, 2024 00:16
@sisyphusSmiling
Copy link
Collaborator Author

sisyphusSmiling commented Nov 18, 2024

Updated transactions to be more generic. In the process, I realized the ExampleNFT implementations didn't conform to the NFT standard so updated those for testing purposes.

@austinkline the util methods added to the transfer transactions are useful elsewhere. I'm wondering if you think StringUtils would be a good place to put them (or maybe some new util like TypeUtils) since they're generally useful.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review November 18, 2024 22:59
@sisyphusSmiling sisyphusSmiling merged commit adb47c7 into main Nov 22, 2024
1 check passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-child-nft-txn branch November 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add example txn for bulk movement of NFTs from child to parent account
4 participants