redis: Add GETDEL command support (envoyproxy#31448)

Add GETDEL command support Signed-off-by: Ilya Nemakov <[email protected]>
ongres · Dec 28, 2023 · 21323d4 · 21323d4
1 parent 251dcaf
commit 21323d4
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/changelogs/current.yaml b/changelogs/current.yaml
@@ -323,6 +323,9 @@ new_features:
 - area: lua
   change: |
     Added lua extension of router cluster specifier plugin to support selecting cluster dynamically by lua code.
+- area: redis
+  change: |
+    Added support for the getdel command.
 
 deprecated:
 - area: wasm

diff --git a/docs/root/intro/arch_overview/other_protocols/redis.rst b/docs/root/intro/arch_overview/other_protocols/redis.rst
@@ -238,6 +238,7 @@ For details on each command's usage see the official
   DECRBY, String
   GET, String
   GETBIT, String
+  GETDEL, String
   GETRANGE, String
   GETSET, String
   INCR, String

diff --git a/source/extensions/filters/network/common/redis/supported_commands.h b/source/extensions/filters/network/common/redis/supported_commands.h
@@ -22,12 +22,12 @@ struct SupportedCommands {
     CONSTRUCT_ON_FIRST_USE(
         absl::flat_hash_set<std::string>, "append", "bitcount", "bitfield", "bitpos", "decr",
         "decrby", "dump", "expire", "expireat", "geoadd", "geodist", "geohash", "geopos",
-        "georadius_ro", "georadiusbymember_ro", "get", "getbit", "getrange", "getset", "hdel",
-        "hexists", "hget", "hgetall", "hincrby", "hincrbyfloat", "hkeys", "hlen", "hmget", "hmset",
-        "hscan", "hset", "hsetnx", "hstrlen", "hvals", "incr", "incrby", "incrbyfloat", "lindex",
-        "linsert", "llen", "lmove", "lpop", "lpush", "lpushx", "lrange", "lrem", "lset", "ltrim",
-        "persist", "pexpire", "pexpireat", "pfadd", "pfcount", "psetex", "pttl", "restore", "rpop",
-        "rpush", "rpushx", "sadd", "scard", "set", "setbit", "setex", "setnx", "setrange",
+        "georadius_ro", "georadiusbymember_ro", "get", "getbit", "getdel", "getrange", "getset",
+        "hdel", "hexists", "hget", "hgetall", "hincrby", "hincrbyfloat", "hkeys", "hlen", "hmget",
+        "hmset", "hscan", "hset", "hsetnx", "hstrlen", "hvals", "incr", "incrby", "incrbyfloat",
+        "lindex", "linsert", "llen", "lmove", "lpop", "lpush", "lpushx", "lrange", "lrem", "lset",
+        "ltrim", "persist", "pexpire", "pexpireat", "pfadd", "pfcount", "psetex", "pttl", "restore",
+        "rpop", "rpush", "rpushx", "sadd", "scard", "set", "setbit", "setex", "setnx", "setrange",
         "sismember", "smembers", "spop", "srandmember", "srem", "sscan", "strlen", "ttl", "type",
         "watch", "zadd", "zcard", "zcount", "zincrby", "zlexcount", "zpopmin", "zpopmax", "zrange",
         "zrangebylex", "zrangebyscore", "zrank", "zrem", "zremrangebylex", "zremrangebyrank",
@@ -92,12 +92,12 @@ struct SupportedCommands {
   static const absl::flat_hash_set<std::string>& writeCommands() {
     CONSTRUCT_ON_FIRST_USE(absl::flat_hash_set<std::string>, "append", "bitfield", "decr", "decrby",
                            "del", "discard", "exec", "expire", "expireat", "eval", "evalsha",
-                           "geoadd", "hdel", "hincrby", "hincrbyfloat", "hmset", "hset", "hsetnx",
-                           "incr", "incrby", "incrbyfloat", "linsert", "lmove", "lpop", "lpush",
-                           "lpushx", "lrem", "lset", "ltrim", "mset", "multi", "persist", "pexpire",
-                           "pexpireat", "pfadd", "psetex", "restore", "rpop", "rpush", "rpushx",
-                           "sadd", "set", "setbit", "setex", "setnx", "setrange", "spop", "srem",
-                           "zadd", "zincrby", "touch", "zpopmin", "zpopmax", "zrem",
+                           "geoadd", "getdel", "hdel", "hincrby", "hincrbyfloat", "hmset", "hset",
+                           "hsetnx", "incr", "incrby", "incrbyfloat", "linsert", "lmove", "lpop",
+                           "lpush", "lpushx", "lrem", "lset", "ltrim", "mset", "multi", "persist",
+                           "pexpire", "pexpireat", "pfadd", "psetex", "restore", "rpop", "rpush",
+                           "rpushx", "sadd", "set", "setbit", "setex", "setnx", "setrange", "spop",
+                           "srem", "zadd", "zincrby", "touch", "zpopmin", "zpopmax", "zrem",
                            "zremrangebylex", "zremrangebyrank", "zremrangebyscore", "unlink");
   }