Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub those logs #106

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Scrub those logs #106

merged 3 commits into from
Sep 11, 2023

Conversation

akwizgran
Copy link
Collaborator

This branch prevents some sensitive info from being logged:

  • Local port numbers are scrubbed
  • Logs that use java.util.logging (specifically onionwrapper) are directed through Logback so we can scrub them too
  • Onion hostname (and path, when Use a random path to prevent other apps from accessing content #103 is merged) are not logged as a consequence of logging the Sharing state
  • HTTP request logs are only enabled for debug builds

Also, a second commit removes some code for the unused :tor service process.

Fixes #105.

@akwizgran akwizgran requested a review from grote September 8, 2023 13:52
Copy link
Collaborator

@grote grote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and good find on that dead isTorProcess code.

@grote grote merged commit a138812 into main Sep 11, 2023
@grote grote deleted the scrub-those-logs branch September 11, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web server's port number is logged
2 participants